Re: [libvirt] [RFC v3 PATCH 5/5] PowerPC : Add address-type "spapr-vio"

On 11/29/2011 10:03 AM, Prerna Saxena wrote: > @@ -3048,6 +3087,7 @@ virDomainControllerDefParseXML(xmlNodePtr node, > } > > if (def->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE && > + def->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO && > def->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) { > virDomainReportError(VIR_ERR_INTERNAL_ERROR, "%s", > _("Controllers must use the 'pci' address type")); Is this still the proper error message for this type of bus? You may want to look at def->os.arch / def->os.machine to see what is expected here in terms of bus and then have a more specific error message.