On Tue, 2011-11-29 at 12:16 -0500, Stefan Berger wrote:
On 11/29/2011 10:03 AM, Prerna Saxena wrote:
@@ -3048,6 +3087,7 @@ virDomainControllerDefParseXML(xmlNodePtr node, }
if (def->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE && + def->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO && def->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) { virDomainReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Controllers must use the 'pci' address type")); Is this still the proper error message for this type of bus? You may want to look at def->os.arch / def->os.machine to see what is expected here in terms of bus and then have a more specific error message.
No it's not the right message, which is why we're adding that check to skip the message if the controller has an spapr-vio address. So I don't think we need to anything else with arch/machine. cheers