On Wed, Jan 24, 2018 at 02:59:17PM +0100, Ján Tomko wrote:
+ a "Signed-off-by" line to every commit message. The presence
"line containing the contributor's name and e-mail" maybe? I presume just 'Signed-off-by' is not enough for the "legal snake oil", even though it's all the git hook asks for.
Yes, good point - it ought to be the name of the person who contributed the patch, which is usually, but not always also the author.
+ of this line attests that the contributor has read the + above lined DCO and agrees with its statements. + </p></li>
The indentation is off in the above paragraph.
Other than that it looks good, so
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
but I'm wondering if we need some sort of vote or agreement at the community level before this can be formalized and enforced.
There will never be agreement.
But from the git hook thread: In favor: Dan, John, Michal(?) Indifferent: Erik Against: Me, Peter
Which already is some kind of vote, so I'll give this one: "Meh, ACK, please don't try to make another tag mandatory in the future"
Thankyou, none the less I don't want to just push it through while an explicit NACK from stands, depsite a number of others in favour. Simple majority voting is too crude and leads to unhappiness if someone does feel so strongly about a proposal that they want to veto it. So I will wait to see if, given the range of opinions, Peter would be ok with the proposal being applied, despite his previous nack. I had considered whether we should require a Reviewed-by tags to show that someone other than the author has reviewed a patch before it is pushed. It is not practical to check this automatically though, given that we like the flexibility to be able to push build-breaker fixes or trivial fixes, etc as-is. So I won't propose making anything else mandatory - at very most I'd encourage, but *not* require, other tags. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|