On Tue, Nov 25, 2025 at 03:52:34AM -0500, Andrea Bolognani wrote:
On Mon, Nov 24, 2025 at 04:17:13PM +0100, Peter Krempa via Devel wrote:
Summary: Storage driver plugin for ZFS Requires: libvirt-daemon-driver-storage-core = %{version}-%{release} Requires: libvirt-libs = %{version}-%{release} -# Support any conforming implementation of zfs +# Starting with Fedora 43 the 'zfs-fuse' is no longer shipped but obtainable +# externally. The package builds fine without these. Users will have to provide +# their own implementation. + %if 0%{?fedora} && 0%{?fedora} < 43 Requires: /sbin/zfs Requires: /sbin/zpool + %endif
Can we make these Recommends in F43+ instead of dropping the dependency entirely? I'm not sure how the automatic package checks would handle that, but it's what we do in Debian in order to provide at least some hint to the user that additional packages are needed to actually make the package usable.
That is not permitted https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/ "As with regular dependencies, weak dependencies MUST be satisfiable within the official Fedora repositories." With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|