Re: [Libvir] [PATCH] Xen driver doesn't support autostart, so remove it from xen_unified
On Fri, Jun 22, 2007 at 02:08:10PM +0100, Richard W.M. Jones wrote:
Our implementation of the Xen driver doesn't support autostart[*].
However xen_unified.c has a loop for get/setAutostart which causes it to
return an error without setting virterror first. This patch removes
that loop.
Rich.
[*] Although Xen supports it, by putting files in /etc/xen/autostart/
(at least that was the "old Xen" way before the current insanity of
getting rid of config files was invented).
Hum, if we are desesperate of ever adding the support to Xen,
then okay, but wouldn't it be better to emit the error before returning
in case no Xen sub-driver supports it ?
just wondering, +1 otherwise.
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/