Re: [libvirt] [PATCH v4 03/11] nvdimm: introduce 'unarmed' element into xml for NVDIMM memory
On 12/20/2018 12:07 AM, Daniel P. Berrangé wrote:
On Tue, Dec 18, 2018 at 09:50:40AM +0800, Luyao Zhong wrote:
>
>
> On 2018/12/17 下午7:07, Daniel P. Berrangé wrote:
>> On Mon, Dec 17, 2018 at 05:26:13PM +0800, Luyao Zhong wrote:
>>> The 'unarmed' option allows users to mark vNVDIMM read-only:
>>
>> Why don't we call this element <readonly/> then ?
>>
> Just keep the same with QEMU, hah~ :)
Well lets call it 'readonly' in libvirt because 'unarmed' tells
users nothing useful.
Got it! I'll update in next version patch.
Regards,
Daniel
Thank you for your comments.
Regards,
Luyao