On 4/25/19 7:46 AM, Peter Krempa wrote:
On Wed, Apr 17, 2019 at 09:09:10 -0500, Eric Blake wrote:
Commits 4bc42986 and 218c81ea removed virDomainStorageSourceFormat on the grounds that there were no external callers; however, the upcoming backup code wants to output a <target> (push mode) or <scratch> (pull mode) element that is in all other respects identical to a domain's <source> element, where the previous virDomainStorageSourceFormat fit the bill nicely. But rather than reverting the commits, it's easier to just add an additional parameter for the element name to use, and update all callers.
Signed-off-by: Eric Blake <eblake@redhat.com> --- src/conf/domain_conf.h | 1 + src/conf/domain_conf.c | 14 +++++++++----- src/conf/snapshot_conf.c | 3 ++- src/qemu/qemu_domain.c | 2 +- tests/qemublocktest.c | 3 ++- tests/virstoragetest.c | 2 +- 6 files changed, 16 insertions(+), 9 deletions(-)
ACK
I've pushed this one. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org