On Tue, Nov 18, 2008 at 01:16:46PM -0500, David Lively wrote:
On Mon, 2008-11-17 at 22:22 +0000, Daniel P. Berrange wrote:
On Mon, Nov 17, 2008 at 03:55:13PM -0500, David Lively wrote:
Functionally this all looks fine.
From a style point of view, we should keep consistency with the other virEventAddHandle func in terms of typing / param ordering. I prefer to have a typedef for the 'freefunc', even though its trivial, because I hate reading function prototypes :-) Whether we have the freefunc, before or after the 'void opaque' in the register method I don't really mind one way or the other as long as we're consistent. Having the freefunc last is probably best, since its very often just going to be NULL.
Daniel
Ok, here's a version with "virFreeCallback" as the "freefunc" (now called "freecb") typedef.
Thanks I've committed this patch now. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|