Re: [libvirt] [PATCH 2/2] add --live support to "virsh dump"
On 11/30/2009 03:29 PM, Daniel P. Berrange wrote:
On Mon, Nov 30, 2009 at 10:11:11AM +0100, Paolo Bonzini wrote:
> This is trivial for QEMU since you just have to not stop the vm before
> starting the dump.
>
> In Xen it is buggy, so I chose to not support it.
Well some versions of Xen are buggy, but not neccessarily all of
them. IMHO we should support it in libvirt because it is a trivial
change to make. This at least lets users try the functionality and
see if there are bugs in their version of Xen
eg, our code already does
return xend_op(domain->conn, domain->name, "op", "dump",
"file", filename,
"live", "0", "crash", "0",
NULL);
so it is easy to set "live", "1" based on flags
That's fine by me, but I would appreciate a second opinion (it can also
be done as a follow up, anyway).
Paolo