Re: [libvirt] [PATCH] doc: Add doc for missed options of migrate

On 11/18/2010 01:21 AM, Osier Yang wrote: > * tools/virsh.pod (add doc for options like "--p2p", "--direct", > "--copy-storage-all", "dname", etc.) > --- > tools/virsh.pod | 23 ++++++++++++++++------- > 1 files changed, 16 insertions(+), 7 deletions(-) > ACK to the general fix; I made these grammar tweaks, then pushed:

diff --git i/tools/virsh.pod w/tools/virsh.pod index 036848d..bc1e8e5 100644 --- i/tools/virsh.pod +++ w/tools/virsh.pod @@ -461,17 +461,18 @@ I<--persistent> I<--undefinesource> I<--suspend> I<--copy-storage-all> I<--copy-storage-inc> I<domain-id> I<desturi> I<migrateuri> I<dname> Migrate domain to another host. Add I<--live> for live migration; I<--p2p> -for peer-2-peer migration; I<--direct> for direct migration; I<--tunnelled> -for tunnelled migration; I<--persistent> leaves the domain persistent on -destination host, I<--undefinesource> undefine the domain on source host, -I<--suspend> leaves the domain paused on the destination host. +for peer-2-peer migration; I<--direct> for direct migration; or I<--tunnelled> +for tunnelled migration. I<--persistent> leaves the domain persistent on +destination host, I<--undefinesource> undefines the domain on the source host, +and I<--suspend> leaves the domain paused on the destination host. I<--copy-storage-all> indicates migration with non-shared storage with full disk copy, I<--copy-storage-inc> indicates migration with non-shared storage with incremental copy (same base image shared between source and destination). + The I<desturi> is the connection URI of the destination host, and I<migrateuri> is the migration URI, which usually can be omitted. I<dname> is used for renaming the domain to new name during migration, which -also usually can be ommited. +also usually can be omitted. =item B<migrate-setmaxdowntime> I<domain-id> I<downtime>