Re: [libvirt] [PATCH 1/2]virsh: enable attatch-disk command option '--mode' accept two parameters
-----Original Message-----
From: Daniel P. Berrange [mailto:berrange@redhat.com]
Sent: Tuesday, October 15, 2013 6:09 PM
To: Chen Hanxiao
> Do you mean that we should erase all about parameter 'shareable'?
> Not only '--shareable' but also in '--mode shareable'?
> If we decided to keep readonly and shareable in '--mode', we had to deal
with
> accepting two parameters at the same command line.
No, a disk can be in one of three modes
- Exclusive read-write. This is the default
- Shared read-write. This is the <shareable/> flag
- Shared read-only. This is the <readonly/> flag
It makes no sense to support both <shareable/> and <readonly/> in the
same XML config at once.
But we could do this with --sharebale --mode readonly or edit XMLs.
I'll try to fix this conflict: let this could not happen in virsh command.
Thanks!
Daniel