On Fri, 2016-02-19 at 11:05 -0500, John Ferlan wrote:
On 02/18/2016 10:28 AM, Andrea Bolognani wrote:
GIC v2 is the default, but checking against that specific version when we want to know whether the default has been selected is potentially error prone; using an alias instead makes it safer. --- src/qemu/qemu_command.c | 7 +++---- src/qemu/qemu_domain.c | 4 ++-- src/util/virgic.h | 3 +++ 3 files changed, 8 insertions(+), 6 deletions(-)
This works, but so does I think changing VIR_GIC_VERSION_2 in virgic.h to VIR_GIC_VERSION_DEFAULT
ACK either way, but I think changing _2 to _DEFAULT would be better...
That would hide the fact that v2 is the default version, though. I've pushed it as is, thanks for the review. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team