21 Mar
2014
21 Mar
'14
10:17 p.m.
On 03/19/2014 11:20 AM, Eric Blake wrote:
Part of a series of cleanups to use new accessor methods.
* src/xenxs/xen_sxpr.c (xenParseSxprDisks, xenParseSxpr) (xenFormatSxprDisk, xenFormatSxpr): Use accessors. * src/xenxs/xen_xm.c (xenParseXM, xenFormatXMDisk, xenFormatXM): Likewise.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
This one is a bit trickier to review, in that it is replacing in-place strndup over to calls to a function that mallocs a copy of the input string.
I looked through those sections and they all *appear* to be correct (in particular, you didn't forget to update your "src" pointer after the disk->src had been changed). But if you want to wait for someone who can actual test xenxs be my guest.