On Mon, Nov 17, 2008 at 03:17:42PM +0100, Daniel Veillard wrote:
On Mon, Nov 17, 2008 at 01:27:26PM +0000, Daniel P. Berrange wrote:
On Mon, Nov 17, 2008 at 01:05:30PM +0000, Daniel P. Berrange wrote:
On Mon, Nov 17, 2008 at 01:03:29PM +0100, Daniel Veillard wrote:
On Fri, Nov 14, 2008 at 05:44:29PM +0000, Daniel P. Berrange wrote:
As per our earlier discussion today, this patch expands the callback for domain events so that it also gets a event type specific 'detail' field. This is also kept as an int, and we define enumerations for the possible values associated with each type. [...]
Okay, that made the overall callbacks set clearer, ACK
If a event type has no detail, 0 is passed.
Actually I would define a detail enum for all event type just to make clear what the value will be and expose how it's intended to be extended if needed.
This new patch does that now.
Okay, just one minor suggestion, in eventDetailToString() make a case for all event types and drop default: so the compiler warns us if we forgot to update the function when there is an addition to one of the enums.
Ok, made that change & comitted it. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|