Re: [libvirt PATCH 321/351] meson: docs: introduce meson-html-gen.py helper
On Tue, Jul 28, 2020 at 04:52:18PM +0200, Peter Krempa wrote:
On Tue, Jul 28, 2020 at 16:46:55 +0200, Pavel Hrdina wrote:
> On Tue, Jul 28, 2020 at 04:23:15PM +0200, Peter Krempa wrote:
> > On Tue, Jul 28, 2020 at 16:14:03 +0200, Pavel Hrdina wrote:
[...]
> If there majority agrees on removing the script I would rather do it as
> a followup series.
I don't care that much about repetition of build target declarations
accross various subdirectories. In this case I care that stuff is put
into a script which doesn't need to be there and meson can handle it
just fine. In the end many of the subdirectories do it directly.
The issue with repetition is a possibility to forget to change all
places in the future if we need to modify the code.
Fair enough, but you should compile a list of all that stuff you want
to
postpone as part of the final submission so that it won't be forgotten.
I have that list together with all the fixes done based on review and
other fixes that where needed because of changes in master.
I'll include all of the notes with all the changes when sending a mail
with v2.
Pavel
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)