On Wed, Jun 20, 2012 at 02:41:20PM +0100, Daniel P. Berrange wrote:
On Fri, May 11, 2012 at 11:16:42PM +0200, Guido Günther wrote:
> On Wed, May 09, 2012 at 10:00:47AM -0600, Eric Blake wrote:
> > On 05/09/2012 09:49 AM, Daniel P. Berrange wrote:
> > > From: "Daniel P. Berrange" <berrange(a)redhat.com>
> > >
> > > Introduce a new syntax for filesystems to allow use of a RAM
> > > filesystem
> > >
> > > <filesystem type='ram'>
> > > <source usage='1024'/>
> > > <target dir='/mnt'/>
> > > </filesystem>
> > >
> > > The usasge is in KB to limit consumption of host memory.
> >
> > Based on what we learned with <memory>, I think you really want:
> >
> > <source unit='KiB' usage='1024'/>
> >
> > on output, as well as allowing unit='...' for scaling of input such as
> > <source unit='G' usage='1'/> for 2^30 bytes.
>
> virParseScaleValue from "Filesystem limits for containers" might help
> here.
Yes it would. I noticed Eric had a bunch of comments on your v2
posting. Have you got a v3 pending, or shall I take over the
merging of the virParseScaleValue method myself ?
virParseScaledValue is merged (note the extra 'd').
Cheers,
-- Guido