On Thu, 7 Oct 2010 12:45:22 +0100, "Daniel P. Berrange" <berrange@redhat.com> wrote:
On Tue, Sep 28, 2010 at 03:26:15PM +0530, Nikunj A. Dadhania wrote:
+ +/* Set memory tunables for the domain*/ +int virDomainSetMemoryParameters(virDomainPtr domain, + virMemoryParameterPtr params, + int nparams); +/* Get memory tunables for the domain, caller allocates the params if nparams + * is zero and params is NULL, the domain returns back number of parameters + * supported by the HV. This could be used by the caller to allocate the + * memory and call with params structure allocated. + */ +int virDomainGetMemoryParameters(virDomainPtr domain, + virMemoryParameterPtr params, + int *nparams);
We should add an 'unsigned int flags' parameter to both of these, so we can extend their semantics in the future. I have added this and mentioned it as unused at present.
The comment here can be moved to the libvirt.c file so it gets picked up in the API docs.
I have already put a detailed comment in libvirt.c for API docs. I am getting rid of this for now. Nikunj