Re: [libvirt] [PATCH v2 01/10] docs: Clarify unprivileged sgio feature for host devices

I don't mind kernel or hypervisor, although it seems kernel is more technically correct. How about "hypervisor and OS" like is described for the "shareable" attribute which is related? So, how about the following: If supported by the hypervisor and OS, the optional <code>sgio</code> attribute indicates whether unprivileged SG_IO commands are filtered for the disk. Valid settings are "filtered" or "unfiltered", where the default is "filtered". Additionally, given the rest of the conversation, should the <disk> discussion of 'sgio' also be updated similarly? Currently it states: <dd> Indicates whether the kernel will filter unprivileged SG_IO commands for the disk, valid settings are "filtered" or "unfiltered". Defaults to "filtered". Similar to <code>rawio</code>, <code>sgio</code> is only valid for device 'lun'. </dd> e.g If supported by the hypervisor and OS, indicates whether unprivileged SG_IO commands are filtered for the disk. Valid settings are "filtered" or "unfiltered" where the default is "filtered". Only available when the <code>device</code> is 'lun'.

John