On Wed, Oct 16, 2013 at 11:12:46AM +0200, Christophe Fergeau wrote:
On Tue, Oct 15, 2013 at 12:05:02PM -0700, Ian Main wrote:
This patch adds support for setting filterref's on interfaces. Also supported are parameters to the filterref's.
This mostly looks good, some comments below.
Cool, thanks for the review. Mostly straight forward.. just wondering about this one: [snip]
I'm wondering if we should call that method gvir_config_domain_interface_filterref_set_filter_name() so that in the future we can have gvir_config_domain_interface_filterref_set_filter(GVirConfigDomainInterfaceFilterref *ref, GVirConfigNwFilter *filter);
Where would the GVirConfigNwFilter come from? This would be an interface to actually create the filter definition or get a handle for one? Very odd about the missing lines?! Anyway I'll check it out and post another rev. Ian