On Wed, Jul 21, 2021 at 10:13:32AM -0400, Andrea Bolognani wrote:
On Wed, Jul 21, 2021 at 02:07:58PM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 21, 2021 at 03:16:39AM -0700, Andrea Bolognani wrote:
> > Also pre-existing: do we even care about handling upgrades from
> > versions of the daemon that didn't have support for systemd socket
> > passing at this point? The .spec file explicitly limits support to
> > RHEL 8 and Fedora 33, which should be plenty recent enough to make
> > the entire dance unnecessary.
>
> Yes, we need to support upgrades. RHEL only gained socket
> activation in 8.3 (IIRC), and so we need this logic to support
> upgrades from RHEL-7.x or 8.0-8.2
Thinking about this a bit more: is our expectation that you'd be able
to upgrade from your distro-provided libvirt package to one built
from upstream sources? I would definitely consider that to be an
unsupportable, out of scope scenario.
The upstream RPM spec file is the one used for RHEL and Fedora, so
this is clearly the scope.
Regards,
Daniel
--
|:
https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|:
https://libvirt.org -o-
https://fstop138.berrange.com :|
|:
https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|