* AUTHORS: Add recent contributors. ---
- *libVer = LIBVIR_VERSION_NUMBER; - ret = 0; + *libVer = LIBVIR_VERSION_NUMBER; + return 0; error: virDispatchError(conn); return ret;
This change is fine. It would be wrong to report an error there. I'd insert a blank line after the "return 0;"
Done, and pushed. I'm also pushing this followup as trivial. And in doing so, I noticed that we incorrectly attributed one patch to Philip Hahn instead of Philipp Hahn. AUTHORS | 3 ++++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/AUTHORS b/AUTHORS index 1fa97b6..d6f025e 100644 --- a/AUTHORS +++ b/AUTHORS @@ -95,6 +95,9 @@ Patches have also been contributed by: Rolf Eike Beer <eike@sf-mail.de> Wolfgang Mauerer <wolfgang.mauerer@siemens.com> Philipp Hahn <hahn@univention.de> + Ed Swierk <eswierk@aristanetworks.com> + Paolo Smiraglia <paolo.smiraglia@gmail.com> + Sharadha Prabhakar <sharadha.prabhakar@citrix.com> [....send patches to get your name here....] -- 1.6.6.1