On 08.05.2016 19:49, Cole Robinson wrote:
This matches how we handle spice gl='no' even if spice GL isn't supported. Not too interesting in practice but I figure we should be consistent --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 2966b07..c26715f 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4125,7 +4125,7 @@ qemuBuildDeviceVideoStr(const virDomainDef *def, virBufferAsprintf(&buf, "%s,id=%s", model, video->info.alias);
if (video->type == VIR_DOMAIN_VIDEO_TYPE_VIRTIO) { - if (video->accel && video->accel->accel3d) { + if (video->accel && video->accel->accel3d == VIR_TRISTATE_SWITCH_ON) { if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_GPU_VIRGL)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("virtio-gpu 3d acceleration is not supported"));
In fact, this is important in practice. Because if in accel3d had been 'no' we would ignore it and execute the if() statement body. Both VIR_TRISTATE_SWITCH_ON and _OFF have non zero values. ACK Michal