On Thu, Jan 30, 2020 at 03:43:05PM +0100, Erik Skultety wrote:
libpcap-1.5.0 introduced a function to enforce immediate mode (on all platforms) which the follow-up patches will rely on.
Per https://repology.org/project/libpcap/versions RHEL-7 has 1.5.3, Debian 9 has 1.8.1 Ubuntu 1604 has 1.7.4 so I concur that 1.5.0 is a suitable choice.
Signed-off-by: Erik Skultety <eskultet@redhat.com> --- libvirt.spec.in | 2 +- m4/virt-libpcap.m4 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
diff --git a/libvirt.spec.in b/libvirt.spec.in index bbf9748582..b349d1bc7e 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -302,7 +302,7 @@ BuildRequires: yajl-devel %if %{with_sanlock} BuildRequires: sanlock-devel >= 2.4 %endif -BuildRequires: libpcap-devel +BuildRequires: libpcap-devel >= 1.5.0 BuildRequires: libnl3-devel BuildRequires: libselinux-devel BuildRequires: dnsmasq >= 2.41 diff --git a/m4/virt-libpcap.m4 b/m4/virt-libpcap.m4 index 8fa4889ec8..605c2fdea7 100644 --- a/m4/virt-libpcap.m4 +++ b/m4/virt-libpcap.m4 @@ -22,7 +22,7 @@ AC_DEFUN([LIBVIRT_ARG_LIBPCAP], [ ])
AC_DEFUN([LIBVIRT_CHECK_LIBPCAP], [ - LIBPCAP_REQUIRED="1.0.0" + LIBPCAP_REQUIRED="1.5.0" LIBPCAP_CONFIG="pcap-config" LIBPCAP_CFLAGS="" LIBPCAP_LIBS="" -- 2.24.1
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|