On Wed, Apr 14, 2010 at 11:18:47AM +0100, Daniel P. Berrange wrote:
On Tue, Apr 13, 2010 at 02:11:55PM -0600, Eric Blake wrote:
* .gitignore: Add rule that requires . in name, then add exemptions. ---
Given Chris' recent accident in committing a binary file, then blasting the list with it, here's a (hack) approach to prevent a relapse in the future. It assumes that non-binary files either have an extension, or are easy enough to enumerate.
Personally, I do NOT want to apply this patch. It has the nasty side-effect of rendering .git/info/exclude useless (git unfortunately stops processing ignore rules once it finds an explicit accept rule, so any reject rules in .git/info/exclude for files containing '.' are overruled as accepts by this patch). Hence, this is only an RFC, documenting my thought process.
I don't think its really worth it myself. I prefer to have too little in the .gitignore file, than too much, since it ensures you'll spot files you haven't added to the commit.
Chris' patch was actually blocked by mailman, but someone else approved it before I could reject it !
I made the mistake, I went directly to the web front-end and didn't see the binary chunk :-\ Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/