On Tue, Nov 15, 2011 at 04:02:23PM -0700, Eric Blake wrote:
On 11/15/2011 04:35 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
Followup to
https://www.redhat.com/archives/libvir-list/2011-November/msg00580.html
This patch adds support for a systemd init service for libvirtd and libvirt-guests. The libvirtd.service is *not* written to use socket activation, since we want libvirtd to start on boot so it can do guest auto-start.
Looks like you addressed all the v2 review comments.
ACK with one nit:
In v2:
- Fix AC_MSG_HELP wrapping - Fix %makeinstall target - Explicitly handle 'none' for --with-initscript - Revert rename of libvirt-guests.sh
+ [AC_HELP_STRING([--with-init-script@<:@=STYLE@:>@], + [Style of init script to install: redhat, systemd, systemd+redhat, + upstart, auto, none @<:@default=auto@:>@])]) +init_redhat=no +init_systemd=no +case "$with_init_script" in + systemd+redhat) + init_redhat=yes + init_systemd=yes + ;; + systemd) + init_systemd=yes + ;; + redhat) + init_redhat=yes + ;; + none) + ;; + *)
Where is upstart handled? Without an explicit clause, you might be accidentally turning it into with_init_script=redhat.
Ha, I knew I was forgetting one bit. We have never had any rules to actually install the upstart file before, we just included it as an example. Time for a v3 Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|