On Mon, Oct 28, 2024 at 10:32:55AM -0700, Andrea Bolognani wrote:
On Fri, Oct 25, 2024 at 04:44:16PM +0100, Daniel P. Berrangé wrote:
On Fri, Oct 25, 2024 at 12:18:14AM -0400, Laine Stump wrote:
This has been verified (on a Fedora 40 host) to fix DHCP with FreeBSD guests, while not breaking it for Fedora or Windows (10) guests.
You can add OpenBSD to that list, as I tested that too.
I did some testing of my own and I can confirm that FreeBSD and OpenBSD are fine with this change, as are various Linux flavors (Alpine, CirrOS, Debian, Fedora, openSUSE, Ubuntu).
However, a few other operating systems aren't: namely GNU/Hurd, Haiku and NetBSD break with this change. Interestingly, these were all fine with the nftables backend before it.
Well that's odd. I've checked NetBSD source code and found no less than 3 DHCP client impls, and all of them cope with checksum == 0. https://github.com/NetBSD/src/blob/trunk/usr.bin/rump_dhcpclient/net.c#L497 https://github.com/NetBSD/src/blob/trunk/external/bsd/dhcpcd/dist/src/dhcp.c... https://github.com/NetBSD/src/blob/trunk/external/mpl/dhcp/dist/common/packe... the middle impl also directly copes with partial checksums Not identified the Hurd/Haiku DHCP client code yet... With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|