Re: [libvirt] [RFC PATCHv4 13/15] qemu: consolidate migration to file code

On Wed, Mar 09, 2011 at 07:18:31PM -0700, Eric Blake wrote: > This points out that core dumps (still) don't work for root-squash > NFS, since the fd is not opened correctly. This patch should not > introduce any functionality change, it is just a refactoring to > avoid duplicated code. > > * src/qemu/qemu_driver.c (qemuDomainMigrateToFile): New function. > (qemudDomainSaveFlag, doCoreDump): Use it. I think it could be worth moving this method into qemu_migrate.h/.c now it is decoupled from the public API objects/methods.

ACK to the refactoring regardless.