Re: [PATCH v1 2/4] qemu_domain.c: do not launch ppc64 guests with 'pvspinlock' setting

23 Mar 2020


      On Thu, 2020-03-19 at 18:44 -0300, Daniel Henrique Barboza wrote:
[...]
...
+        case VIR_DOMAIN_FEATURE_PVSPINLOCK:
+            if (def->features[i] != VIR_TRISTATE_SWITCH_ABSENT &&
+                ARCH_IS_PPC64(def->os.arch)) {
+                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                               _("The '%s' feature is not supported for "
+                                 "architecture '%s' or machine type '%s'"),
+                                 featureName,
+                                 virArchToString(def->os.arch),
+                                 def->os.machine);
+                 return -1;
Same comment as the previous patch: the feature is x86-only, so
there's no point in only preventing its use on ppc64.

-- 
Andrea Bolognani / Red Hat / Virtualization