Re: [libvirt] [PATCH 5/9] vsh: Add helper for safe remembering of libvirt errors

On Tue, Apr 11, 2017 at 05:53:51PM +0200, Peter Krempa wrote:

Avoid the annoying issue where the public object freeing APIs overwrite the error set by helper functions, since they don't invoke the callback.

The new helper remembers the error only if no previous error was set. --- tools/virsh-util.c | 2 ++ tools/vsh.c | 15 +++++++++++++++ tools/vsh.h | 1 + 3 files changed, 18 insertions(+)

ACK Jan