Re: [libvirt] [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

On Fri, Mar 09, 2012 at 04:07:43PM +0000, Stefan Hajnoczi wrote:

Paolo, your discard improvements in QEMU add FALLOC_FL_PUNCH_HOLE support. XFS supports this fallocate() flag in current kernels, thereby making the XFS-specific support obsolete.

I'm wondering whether it's worth expanding the SELinux policy if we will have no fstatfs(2) callers in QEMU. Are you planning to drop the XFS code?

FALLOC_FL_PUNCH_HOLE is a very recent feature, while the ioctl has been around for more than 10 years. Using FALLOC_FL_PUNCH_HOLE by default is fine, so systems that have selinux and support it will still work.