Re: [libvirt] [PATCH] check device-mapper when building without storage mpath

On 18/02/2011, at 8:07 PM, Wen Congyang wrote: > At 02/18/2011 05:00 PM, Justin Clift Write: >> On 18/02/2011, at 7:46 PM, Jiri Denemark wrote: >> <snip> >>> >>>> Thanks for the fix, actually It can be reproduced simply by: >>>> % ./autogen.sh --with-storage-mpath=no >>>> % make >>>> >>>> As src/util/util.c invokes "dm_is_dm_major". >>> >>> Yes it does, but I'm not convinced this is the right approach to fix it. Why >>> should libvirt always require device-mapper libraries? >> >> As a data point, device-mapper isn't available on non-Linux platforms. If >> Osier was meaning to make it "required", I can see a problem about there. ;) > > Do we build storage mpath on such platforms? No. This is the ./configure output on OSX using libvirt 0.8.8, with most of the stuff enabled that can be made to compile:

Hope that's useful info. :)

Regards and best wishes, Justin Clift