Re: [libvirt] [PATCH] storage: Avoid leak in virStorageUtilGlusterExtractPoolSources()

On 04/05/2017 12:28 PM, Andrea Bolognani wrote: > The contents of volname would be leaked if the function were > to be passed an invalid pooltype by the caller. > > Make sure the memory is released instead. > --- > Initializing volname to NULL is strictly speaking not > necessary, but I like it better that way :) > > src/storage/storage_util.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > This could be "as easy as" just adding a VIR_FREE(volname) in the "} else {" case prior to virReportError and goto cleanup; If you went with this option, then VIR_STEAL_PTR(src->dir, volname); and VIR_STEAL_PTR(src->name, volname); instead of inlining.

And as some would say the comment is "obvious".