Re: [libvirt] [PATCH 03/15] Export conditional state driver symbols only when they are defined
2010/3/22 Daniel P. Berrange <berrange(a)redhat.com>:
On Mon, Mar 22, 2010 at 02:25:33AM +0100, Matthias Bolte wrote:
> This is necessary for MinGW builds.
> ---
> src/Makefile.am | 7 ++++++-
> src/libvirt_daemon.syms | 10 ++++++++++
> src/libvirt_private.syms | 5 -----
> 3 files changed, 16 insertions(+), 6 deletions(-)
> create mode 100644 src/libvirt_daemon.syms
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index c6371fb..08e204d 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -813,13 +813,18 @@ if WITH_MACVTAP
> USED_SYM_FILES += libvirt_macvtap.syms
> endif
>
> +if WITH_LIBVIRTD
> +USED_SYM_FILES += libvirt_daemon.syms
> +endif
> +
> EXTRA_DIST += \
> libvirt_public.syms \
> libvirt_private.syms \
> libvirt_driver_modules.syms \
> libvirt_bridge.syms \
> libvirt_linux.syms \
> - libvirt_macvtap.syms
> + libvirt_macvtap.syms \
> + libvirt_daemon.syms
>
> BUILT_SOURCES = libvirt.syms
>
> diff --git a/src/libvirt_daemon.syms b/src/libvirt_daemon.syms
> new file mode 100644
> index 0000000..eb6e594
> --- /dev/null
> +++ b/src/libvirt_daemon.syms
> @@ -0,0 +1,10 @@
> +#
> +# These symbols are dependent upon --with-libvirtd via WITH_LIBVIRTD.
> +#
> +
> +# libvirt_internal.h
> +virStateInitialize;
> +virStateCleanup;
> +virStateReload;
> +virStateActive;
> +virRegisterStateDriver;
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index c5ee23d..5d30b90 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -285,10 +285,6 @@ iptablesRemoveUdpInput;
>
>
> # libvirt_internal.h
> -virStateInitialize;
> -virStateCleanup;
> -virStateReload;
> -virStateActive;
> virDrvSupportsFeature;
> virDomainMigratePrepare;
> virDomainMigratePerform;
> @@ -299,7 +295,6 @@ virDomainMigratePrepareTunnel;
> virRegisterDriver;
> virRegisterInterfaceDriver;
> virRegisterNetworkDriver;
> -virRegisterStateDriver;
> virRegisterStorageDriver;
> virRegisterDeviceMonitor;
> virRegisterSecretDriver;
> --
ACK
Daniel
Thanks, pushed.
Matthias