Re: [libvirt] [PATCH v3 4/4] storage: fs: Only force directory permissions if required

On 05/21/2015 04:03 PM, Cole Robinson wrote:

Only set directory permissions at pool build time, if:

- User explicitly requested a mode via the XML - The directory needs to be created - We need to do the crazy NFS root-squash workaround

This allows qemu:///session to call build on an existing directory like /tmp. --- v3: Minor code clarity tweaks Drop an unused variable while I'm here

src/storage/storage_backend_fs.c | 29 ++++++++++++++++++----------- src/util/virfile.c | 4 ++-- 2 files changed, 20 insertions(+), 13 deletions(-)

ACK John