Re: [libvirt] [PATCH 03/11] Replace virNetworkFree with virObjectUnref
On 12/02/2014 10:14 AM, Peter Krempa wrote:
On 12/01/14 16:56, John Ferlan wrote:
> Since virNetworkFree will call virObjectUnref anyway, let's just use that
> directly so as to avoid the possibility that we inadvertently clear out
> a pending error message when using the public API.
>
> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
> ---
> cfg.mk | 4 ++--
> daemon/remote.c | 7 +++----
> src/conf/network_conf.c | 6 ++----
> src/conf/network_event.c | 2 +-
> src/libxl/libxl_conf.c | 7 +------
> src/lxc/lxc_driver.c | 8 +-------
> src/lxc/lxc_process.c | 8 +-------
> src/qemu/qemu_command.c | 8 +-------
> src/qemu/qemu_hotplug.c | 8 +-------
> src/remote/remote_driver.c | 5 ++---
> src/uml/uml_conf.c | 2 +-
> src/xenconfig/xen_common.c | 2 +-
> src/xenconfig/xen_sxpr.c | 2 +-
> 13 files changed, 18 insertions(+), 51 deletions(-)
>
ACK
Note that this will require a rebase, as I pushed my patch that changed
a single occurrence (because we may not want to backport this larger patch)