On Sat, Aug 20, 2016 at 09:00:37 -0400, John Ferlan wrote:
On 08/19/2016 10:38 AM, Peter Krempa wrote:
Version 2 attempts to address feedback on v1: - added more documentation - fixed various typos - fixed bugs appearing when restarting daemon - fixed fallback code - tested upgrade of libvirt
Some of the patches were already pushed and this series is rebased on top of that changes.
Patches 1-18 with exception of 16 were more or less ACKed already.
I've dropped the last patch adding the events from this series. I'm working on adding a new event for vcpu lifecycle. I'm also working on reporting of the vcpu granularity via the domcapabilities API. I'm going to post those separately as well as the new API that will allow modifying the vcpus individually.
[...]
Went through them all - made a few comments along the way (along with a face palm one). Nothing major seen - although I think the rules for qemu usage will certainly trip someone up! It's "too bad" some of those
I'll post a patch that describes the qemu caveats in the web documentation later (mostly as it will certainly contain typos and wrong phrasing as usual :) )
architectural differences couldn't have been hidden by qemu.
At least we can try to hide that.
ACK series -
Thanks for going through it, some of the functions are unpleasant. Peter