Re: [libvirt] [PATCHv4 12/15] qemu: use common API for reading difficult files

On 03/10/2011 05:14 AM, Daniel P. Berrange wrote: > On Wed, Mar 09, 2011 at 07:18:30PM -0700, Eric Blake wrote: >> Direct access to an open file is so much simpler than passing >> everything through a pipe! > > Did you test with SELinux in enforcing mode - there's a very > slight chance this could impact things, though I think we > do label all FDs correctly these days. Yes, I did, and things still worked to a local disk (where I'm assuming SELinux enforcing would have stopped me). In fact, when passing the fd via SCM_RIGHTS, things still worked even without relabeling the file (although I have no idea if that's a hole in SELinux enforcing).