Re: [libvirt] [PATCH 5/8] Add virConnectPtr for qemuBuildSCSIHostdevDrvStr
On 07/21/2014 04:14 PM, Eric Blake wrote:
On 07/11/2014 06:35 AM, John Ferlan wrote:
> Add a conn for future patches to be able to grab the secret when
> authenticating an iSCSI host device
>
> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
> ---
> src/qemu/qemu_command.c | 5 +++--
> src/qemu/qemu_command.h | 5 +++--
> src/qemu/qemu_driver.c | 6 +++---
> src/qemu/qemu_hotplug.c | 34 ++++++++++++++++++++--------------
> src/qemu/qemu_hotplug.h | 9 ++++++---
> 5 files changed, 35 insertions(+), 24 deletions(-)
I'm not sure if our goal has been to get rid of passing the conn through
by having smarter callbacks, but if it is, this moves in the opposite
direction. But this patch is clean code-wise, as long as there are no
major design concerns.
The code follows the VIR_DOMAIN_DEVICE_NET: option.
It's needed for the secret driver. I do recall we wanted to do
something within the code regarding this type of path, but I forget the
details.
Going to post a v2 shortly.
John