On 11/25/20 3:04 PM, Daniel P. Berrangé wrote:
In testing the "vol-download" command in virsh, downloading
a
1G file takes a ridiculous amount of time (minutes) with the
new SSH helper.
After the first patch is applied the time gets down to a much
more reasonable 5.5 seconds on my test machine.
By comparison netcat achieved 4 seconds.
After applying the second patch, the time is reduced to 3.5
seconds, so we actually end up beating netcat, as long as
we have glib >= 2.64.0 available.
Reviewed-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>
Given the annoyance of the regression it fixes I believe it's worth
pushing it through the release freeze.
Thanks,
DHB
Daniel P. Berrangé (2):
remote: make ssh-helper massively faster
util: avoid glib event loop workaround where possible
src/remote/remote_ssh_helper.c | 113 ++++++++++++++++++++-------------
src/util/vireventglib.c | 29 ++++++---
2 files changed, 89 insertions(+), 53 deletions(-)