On Fri, May 22, 2015 at 09:30:53AM -0400, Cole Robinson wrote:
On 05/22/2015 09:28 AM, Daniel P. Berrange wrote:
> On Fri, May 22, 2015 at 09:26:10AM -0400, Cole Robinson wrote:
>> Once the repos are up, if anyone wants to help watch for pull-requests, you
>> can just 'watch' the repo and you'll receive email notifications when
new
>> pull-requests come in (might need a tweak in your github settings to set up
>> how notifications are delivered, I can't remember exactly)
>
> Sounds like you could just create an account with libvir-list(a)redhat.com
> as the email addr, but that's pretty gross :-) So its fine to just let
> individual people watch if they want to.
>
I experimented with it before, the big problem is that password reminders are
then sent to that list, and the reminder email can be triggered by anyone, so
yeah it's quite gross :)
having github mirror is fine, having
libvirt.org post-push hook that
pushes it there is even better. But it shouldn't be in any way
connected to the list IMHO. Let's just get few people have their
account there closing the requests as suggested -- closed with a link
to the pull request that says something in the lines of:
We don't do pull requests, instead just do:
git config --local sendemail.to libvir-list(a)redhat.com
git send-email [--cover-letter --annotate] master
I'm fine with pointing people there once in a while if we can't come
up with a script (I don't even know whether there's an API we could
use). I use github once in a while.
- Cole
>>
>>> Since I already own the
gitlab.com account for this, I might as well own
>>> the
github.com account to and set them up to use the same sync process.
>>>
>>> [1]
https://gitlab.com/groups/libvirt
>>>
>>
>> Cool, thanks. I'd like access to be able to close pull-requests, but I
don't
>> know if permissions can be that fine grained...
>
> Ok, I'll look into that. My intent would be to setup a dedicated user
> account for the cron job to push, with no one else having write privs.
> If we need write privs to allow closing pull-requests though, I'm sure
> we can trust individuals like yourself not to misuse/abuse that.
>
> Regards,
> Daniel
>
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list