Re: [libvirt] [PATCH] qemu: don't log failure during QMP add-fd probe

On 02/05/2013 08:59 AM, Daniel P. Berrange wrote:

On Tue, Feb 05, 2013 at 08:54:57AM -0700, Eric Blake wrote:

...

Otherwise, we get a lot of scary (but harmless) noise in the logs:

2013-02-05 15:35:48.555+0000: 8637: error : qemuMonitorJSONCheckError:353 : internal error unable to execute QEMU command 'add-fd': Parameter 'fdset-id' expects an existing fdset-id

one for every qemu 1.2 binary that we probe.

* src/qemu/qemu_monitor_json.c (qemuMonitorJSONAddFd): During probe, avoid logging failures. ---

ACK

Thanks; pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org