On Thu, Feb 08, 2018 at 02:19:36PM -0500, Laine Stump wrote:
When the nwfilter tests were added, the config for *all* test domains was changed to apply the "clean-traffic" filter. This doesn't have an ill effect on any test that I know of, but if nwfilter code happened to be broken in just the right way, other tests that might be unrelated could fail as well.
This patch changes the default nwfilter from "clean-traffic" to nothing, and explicitly sets clean-traffic for those tests that require it.
Signed-off-by: Laine Stump <laine@laine.org> ---
New in V2. This was formerly a part of the previous patch.
lib/Sys/Virt/TCK.pm | 4 ++-- scripts/nwfilter/100-ping-still-working.t | 3 ++- scripts/nwfilter/210-no-mac-spoofing.t | 3 ++- scripts/nwfilter/220-no-ip-spoofing.t | 3 ++- scripts/nwfilter/240-no-arp-spoofing.t | 3 ++- 5 files changed, 10 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|