Re: [libvirt] [PATCH] Report more correct information for cache control

hi Martin The code looks good to me, I have 1 comment for the granularity’s comment, and another one for the test data. Otherwise, looks perfect, good to learn how to deal with hex

> create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/cache/index0/type It seems you miss cache/index3 ?

> diff --git a/src/conf/capabilities.h b/src/conf/capabilities.h > index ee87d598ef66..d4753db0beec 100644 > --- a/src/conf/capabilities.h > +++ b/src/conf/capabilities.h > @@ -152,6 +152,7 @@ typedef struct _virCapsHostCacheControl virCapsHostCacheControl; > typedef virCapsHostCacheControl *virCapsHostCacheControlPtr; > struct _virCapsHostCacheControl { > unsigned long long min; /* minimum cache control size in B */ > + unsigned long long granularity; /* minimum increase step for min in B */ The comments may look confused, and it will be better to describe min will be optional if min equal to granularity.

> diff --git a/tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/cache/index0/size b/tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/cache/index0/size > new file mode 100644 > index 000000000000..24a7d60e7fb9 > --- /dev/null > +++ b/tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/cache/index0/size > @@ -0,0 +1 @@ > +11264K > > I checked that on SKX, the cache size is 33792K (33M), it’s good that it can be divided by 11.