Re: [PATCH 20/31] util: virpcivpd: Remove return value from virPCIVPDResourceUpdateKeyword

On a Tuesday in 2024, Peter Krempa wrote: > The function always succeeded and after the removal of programing error > checks doesn't even have a 'return false' case. Additionally one of the > tests in 'virpcivpdtest' tested that this function never failed on wrong > data. Embrace this logic and remove the return value and adjust logging > to VIR_DEBUG level to avoid spamming logs. > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > --- > src/util/virpcivpd.c | 31 +++++++++++-------------------- > src/util/virpcivpd.h | 8 +++++--- > tests/virpcivpdtest.c | 38 ++++++++++++++++++-------------------- > 3 files changed, 34 insertions(+), 43 deletions(-) > > diff --git a/tests/virpcivpdtest.c b/tests/virpcivpdtest.c > index 20545759d5..a6311bfe76 100644 > --- a/tests/virpcivpdtest.c > +++ b/tests/virpcivpdtest.c > @@ -134,10 +130,12 @@ testPCIVPDResourceBasic(const void *data G_GNUC_UNUSED) > > /* Make sure unsupported RW keyword updates are not fatal. */ > for (i = 0; i < numUnsupportedCases; ++i) { > - if (!virPCIVPDResourceUpdateKeyword(res, false, > - unsupportedFieldCases[i].keyword, > - unsupportedFieldCases[i].value)) > - return -1; > + /* This test is deliberately left in despite > + * virPCIVPDResourceUpdateKeyword always succeeding to prevent > + * possible regressions if the function is ever rewritten */ How is this different from any of the pointless tests you removed earlier?