Re: [libvirt] Allow hvsupport.html.in to be auto-generated
On Fri, May 13, 2011 at 05:31:54PM -0600, Eric Blake wrote:
On 05/13/2011 07:36 AM, Daniel P. Berrange wrote:
> The hvsupport.html.in file is constantly out of date, because when
> updating the drivers to add new APIs, people often (always) forget
> to update the hvsupport.html.in file.
>
> To solve this we can instead store version number annotations in
> the drivers themselves, so it is not easily missed. Then the
> hvsupport.html.in file can be auto-generated
I love the idea! But I ran out of time to finish reviewing it today.
Did you test VPATH builds? (autogen.sh will help). Did you test 'make
distcheck' to ensure the tarball is complete?
There was a small typo in the makefile rule wrt VPATH builds which
I've not fixed. Everything is correct inside the tarball too.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|