Re: [libvirt PATCH 07/17] qemu: Introduce virQEMUCapsAccelStr
On Wed, Jan 05, 2022 at 09:23:09AM +0000, Daniel P. Berrangé wrote:
On Tue, Jan 04, 2022 at 07:52:46PM +0100, Andrea Bolognani wrote:
> +static const char *
> +virQEMUCapsAccelStr(virDomainVirtType type)
> +{
> + if (type == VIR_DOMAIN_VIRT_KVM) {
> + return "kvm";
> + } else {
> + return "tcg";
> + }
> +}
..... VIR_ENUM_IMPL/DECL is a better long term plan. For enum
values that don't make sense for QEMU just return a placeholder
or something.
Agreed. Would you accept that as a separate patch that's still part
of this series but applies after all the existing code changes? As I
mention in the cover letter, I tried to keep Roman's original code
intact as much as possible, and I would prefer to avoid making any
non-trivial changes to it to keep the authorship story relatively
straight.
--
Andrea Bolognani / Red Hat / Virtualization