Re: [libvirt] [PATCH 1/1] Don't update vol details after build

* This patch removes the call to vol update after the volume build completes. The update call is currently meaningless anyway because the vol build is passed a copy of the definition, so the update result is thrown away. More importantly, if the user specified a selinux label for the volume, the update call results in a double free of the label. --- src/storage/storage_backend_fs.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index b7d4bd6..4fe40b3 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -822,14 +822,6 @@ _virStorageBackendFileSystemVolBuild(virConnectPtr conn, return -1; } - /* Refresh allocation / permissions info, but not capacity */ - if (virStorageBackendUpdateVolTargetInfoFD(conn, &vol->target, fd, - &vol->allocation, - NULL) < 0) { - close(fd); - return -1; - } - if (close(fd) < 0) { virReportSystemError(conn, errno, _("cannot close file '%s'"),