Re: [libvirt] [PATCH v3 09/36] network: move re-attach of bridge device out of network driver
On 3/22/19 5:41 AM, Daniel P. Berrangé wrote:
On Thu, Mar 21, 2019 at 10:25:21PM -0400, Laine Stump wrote:
> On 3/19/19 8:46 AM, Daniel P. Berrangé wrote:
>> During initial NIC setup the hypervisor drivers are responsible for
>> attaching the TAP device to the bridge device. Any fixup after libvirtd
>> restarts should thus also be their responsibility.
>>
>> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
>
> *And* this fixes a bug that someone reported on IRC awhile back (and does it
> in the correct way, rather than the stupid f'ed up way I would have done it
> if I hadn't completely forgot about it until just this instant :-P)
It isn't supposed to fix any bug ! It should be a no-op refactoring.
What particular bug are you seeing this fix ?
I'd like to describe it if we are fixing something.
Oh wait, you're right. It was near the end of the day and I made the
incorrect leap that the movement caused the code to be executed for all
interfaces, (in particular, those that are <interface type='bridge'>),
not just those that are type='network'. But now I see that it's still
qualified by type == NETWORK, so the situation for interface
type='bridge' is unchanged. So nevermind, carry on.