Re: [libvirt] [PATCH 1/3] Revert "systemd: Escape only needed characters for machined"
On Wed, 2016-02-03 at 14:07 +0100, Pavel Hrdina wrote:
On Tue, Feb 02, 2016 at 09:22:47PM +0100, Martin Kletzander wrote:
> This reverts commit 0e0149ce91d84f40b98acf4c4bb0da6e29b9c15c.
>
> That commit was added to comply with systemd rules that were changed in
> the meantime, so this patch is pointless.
>
> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
> ---
> src/util/virsystemd.c | 23 +++++++----------------
> tests/virsystemdtest.c | 4 ++--
> 2 files changed, 9 insertions(+), 18 deletions(-)
ACK
I have a guest named debian-q35, and after this commit I can no
longer start it:
error: Failed to start domain debian-q35
error: Invalid machine name
Looks like the name gets escaped as
qemu-debian\x2dq35
and systemd doesn't like it. After reverting your revert I can
start the guest again. I'm running
systemd-222-13.fc23.x86_64
which I assume is pretty recent.
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team