On Mon, Nov 06, 2023 at 02:38:54 -0500, Laine Stump wrote:
The long-deprecated use of <driver name='vfio|xen|kvm'/> in domain xml for <hostdev> devices was only ever necessary during the period when libvirt (and the Linux kernel) supported both VFIO and "legacy KVM" styles of hostdev device assignment for QEMU. This became pointless many years ago when legacy KVM device assignment was removed from the kernel, and support for that style of device assignment was completely disabled in the libvirt source in 2019 (commit v5.6.0-316-g2e7225ea8c).
Nevertheless, there were instances of <driver name='vfio'/> in the unit test data that were then (unnecessarily) propagated to several more tests over the years. This patch cleans out those unnecessary explicit settings of driver name='vfio' in all QEMU unit test data, proving that the attribute is no longer (externally) needed while also making it simpler to properly test when a later patch "re-animates" the driver name attribute for a slightly different (but related) use.
Signed-off-by: Laine Stump <laine@redhat.com> ---
Few issues: 1) There are few bits with domain XML bits that seem to mention it: tests/qemuhotplugtestdevices/qemuhotplug-hostdev-pci.xml: <driver name='vfio'/> tests/qemuhotplugtestdomains/qemuhotplug-base-live+hostdev-pci.xml: <driver name='vfio'/> tests/qemuhotplugtestdomains/qemuhotplug-pseries-base-live+hostdev-pci.xml: <driver name='vfio'/> tests/qemumemlockdata/qemumemlock-pc-hardlimit+hostdev.xml: <driver name='vfio'/> tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked+hostdev.xml: <driver name='vfio'/> tests/qemumemlockdata/qemumemlock-pc-hostdev-nvme.xml: <driver name='vfio'/> tests/qemumemlockdata/qemumemlock-pc-hostdev.xml: <driver name='vfio'/> tests/qemumemlockdata/qemumemlock-pc-locked+hostdev.xml: <driver name='vfio'/> tests/qemumemlockdata/qemumemlock-pseries-hardlimit+hostdev.xml: <driver name='vfio'/> tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked+hostdev.xml: <driver name='vfio'/> tests/qemumemlockdata/qemumemlock-pseries-hostdev.xml: <driver name='vfio'/> tests/qemumemlockdata/qemumemlock-pseries-locked+hostdev.xml: <driver name='vfio'/> tests/qemustatusxml2xmldata/modern-in.xml: <driver name='vfio'/> 2) There's documentation that seems to mention it: docs/formatdomain.rst: <driver name='vfio'/> docs/formatnetwork.rst: <driver name='vfio'/> docs/formatnetworkport.rst: <driver name='vfio'/> docs/pci-addresses.rst: <driver name='vfio'/> 3) You are not leaving any example with the existing syntax. To prevent regression, either keep some in or create a specific new test case to cover this now-corner-case. With at least 2 & 3 addressed: Reviewed-by: Peter Krempa <pkrempa@redhat.com>