Re: [PATCH V4 10/11] spec: Remove libvirt-daemon dependency from hypervisor subpackages

23 Dec 2022

      On Thu, Dec 22, 2022 at 11:03:41AM -0700, Jim Fehlig wrote:
...
%package daemon-qemu
 Summary: Server side daemon & driver required to run QEMU guests
+    %if %{with_modular_daemons}
+Requires: libvirt-daemon-common = %{version}-%{release}
+Requires: libvirt-daemon-log = %{version}-%{release}
+Requires: libvirt-daemon-lock = %{version}-%{release}
+Requires: libvirt-daemon-plugin-lockd = %{version}-%{release}
+    %else
 Requires: libvirt-daemon = %{version}-%{release}
+    %endif
%package daemon-kvm
 Summary: Server side daemon & driver required to run KVM guests
+    %if %{with_modular_daemons}
+Requires: libvirt-daemon-common = %{version}-%{release}
+Requires: libvirt-daemon-log = %{version}-%{release}
+Requires: libvirt-daemon-lock = %{version}-%{release}
+Requires: libvirt-daemon-plugin-lockd = %{version}-%{release}
+    %else
 Requires: libvirt-daemon = %{version}-%{release}
+    %endif
%package daemon-lxc
 Summary: Server side daemon & driver required to run LXC guests
+    %if %{with_modular_daemons}
+Requires: libvirt-daemon-common = %{version}-%{release}
+    %else
 Requires: libvirt-daemon = %{version}-%{release}
+    %endif
%package daemon-xen
 Summary: Server side daemon & driver required to run XEN guests
+    %if %{with_modular_daemons}
+Requires: libvirt-daemon-common = %{version}-%{release}
+Requires: libvirt-daemon-lock = %{version}-%{release}
+Requires: libvirt-daemon-plugin-lockd = %{version}-%{release}
+    %else
 Requires: libvirt-daemon = %{version}-%{release}
+    %endif
%package daemon-vbox
 Summary: Server side daemon & driver required to run VirtualBox guests
+    %if %{with_modular_daemons}
+Requires: libvirt-daemon-common = %{version}-%{release}
+    %else
 Requires: libvirt-daemon = %{version}-%{release}
+    %endif
So the xen driver doesn't use virtlogd, and the lxc and vbox drivers
don't use locking either? It's nice that we're making some of the
deployments leaner by default :)

I wonder if we could leave the locking part out for *all* of the
above, with the rationale that it's something that you have to
explicitly enable at the configuration file level anyway. But I guess
that wouldn't work too well when it comes to updates. Maybe after
Enough Time™ has passed?

-- 
Andrea Bolognani / Red Hat / Virtualization